[vlc-devel] [PATCH] vaapi: fix profiles detection.
jpsaman at videolan.org
Tue Dec 6 15:50:26 CET 2011
On Tue, Dec 6, 2011 at 3:43 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> On 06/12/2011 15:16, Jean-Paul Saman wrote:
>> ==> cause of crash, it should be vaMaxNumProfiles( p_va->p_display );
> Of course that's wrong.
> Scrolled through source and ended copying 3 lines lower :/
>>> + while( --i_profiles_nb >= 0 )
>> The coding style in this file uses for-loops in this kind of
>> constructs. Therefor my suggestion is that you do the same.
> I tried to avoid another top declaration as I can't see any inline var
> decl here.
for( int i = 0 ; i < i_profiles_nb; i++ )
is allowed in VLC coding style.
More information about the vlc-devel