[vlc-devel] [Patches] Dash: mostly cosmetics

Tobias Güntner fatbull at web.de
Wed Dec 7 12:39:07 CET 2011


Am 06.12.2011 13:43, schrieb Hugo Beauzée-Luyssen:
> Most of the error handling could be done once and for all after the
> parsing occurred.

Hmmm.

Is the parsing really done if supposedly simple getters can still fail 
because of errors in an input file? Aren't Attribute- and 
ElementNotPresentException actually (tree) parsing errors? Why do most 
getters return strings, although their names suggest otherwise? Why do 
getters returning numbers have to call atoi first, i.e. parse their own 
value? Shouldn't BasicCMParser take care of all these issues *before* 
creating MPD objects?

Regards,
Tobias




More information about the vlc-devel mailing list