[vlc-devel] [vlc-commits] Dxva2 is only available in Windows Vista and above

[Rafaël Carré]

Le Wed, 7 Dec 2011 18:22:35 +0100,
Jean-Baptiste Kempf <jb at videolan.org> a écrit :

> On Wed, Dec 07, 2011 at 12:14:22PM -0500, Rafaël Carré wrote :
> > Le Wed, 7 Dec 2011 18:01:27 +0100,
> > Jean-Baptiste Kempf <jb at videolan.org> a écrit :
> > 
> > > On Wed, Dec 07, 2011 at 05:41:27PM +0100, Rafaël Carré wrote :
> > > > +#  undef _WIN32_WINNT
> > > 
> > > This is a horrible hack.
> > 
> > We use AC_DEFINE to define it to XP compatibility before checking dxva2 headers so it's required
> 
> It isn't required, since we need to check the header presence, not to
> compile them.

Please read autoconf documentation, we do compile them.

> > I found this in libav, it's required to get some helpers like:
> > #define IDirectXVideoDecoder_Release(This) (This)->lpVtbl->Release(This)
> 
> It isn't needed, if you have correctly defined the CINTERFACE, as you
> can clearly see at the bottom of the dxva2api.h file.

I don't know how geal and fenrir wrote this file but if they could
comment that'd be welcome of course.

From libavcodec/dxva2_internal.h:

#define _WIN32_WINNT 0x0600
#define COBJMACROS
#include "dxva2.h"


-- 
Rafaël Carré