[vlc-devel] [PATCH] contrib: remove directx and directshow headers

[Rafaël Carré]

Le Wed, 7 Dec 2011 19:36:40 +0100,
Jean-Baptiste Kempf <jb at videolan.org> a écrit :

> On Wed, Dec 07, 2011 at 01:25:03PM -0500, Rafaël Carré wrote :
> > Le Wed, 7 Dec 2011 18:47:50 +0100,
> > Jean-Baptiste Kempf <jb at videolan.org> a écrit :
> > 
> > > On Wed, Dec 07, 2011 at 12:33:42PM -0500, Rafaël Carré wrote :
> > > > I checked MSDN documentation, the libav commit should have a link to it.
> > > 
> > > It doesn't.
> > 
> > Hm I might have forgotten it, or libav's mailman might have removed it.
> > 
> > In any case: http://msdn.microsoft.com/en-us/library/windows/desktop/bb205892(v=vs.85).aspx
> > 
> > LPDIRECT3DSURFACE9 needs d3d9.h
> 
> Sure, but what I am saying is that other things in dxva2api.h do need
> d3d9.h, like D3DFORMAT, D3DPOOL, so the include should be in dxva2api.h,
> not in the client code.

mingw64's dxva2api.h effectively includes d3d9.h

If the client code uses directly d3d9.h features it should also include
it directly.

Relying on headers including other ones can cause headache, as proved
by our custom dxva2api.h failure to do this.

-- 
Rafaël Carré