[vlc-devel] [PATCH] faad : Reinitializing decoder when we got Unexpected channel configuration change.

[Naohiro KORIYAMA]

2011/12/14 Naohiro KORIYAMA <nkoriyama at gmail.com>:
> 2011/12/14 Jean-Baptiste Kempf <jb at videolan.org>:
>> On Wed, Dec 14, 2011 at 12:06:59AM +0900, Naohiro KORIYAMA wrote :
>>> Duraing playing some video including aac audio, once we got an error
>>> "Unexpected channel configuration change",  same error occurs
>>> afterwards, and we got no sound.
>>>
>>> This patch fixes the aac audio issue.
>>> There are 2 tickets about this issue. #5448, #3714
>>
>> Cool.
>>
>> Is this configuration retrieval/set thread-safe ?
>
>
> At least, I look at the faad2 source, Get/SetCurrentConfiguration:
> - does not access global variables or the heap
> - does not allocate/reallocate/free resources that have global scope
> - does not use indirect accesses through handles or pointers
> - does not have any visible side-effect
>
> So,  I think they are thread safe.
>

I misunderstood what you said.
DecodeBlock() is threaded?


-- 
KORIYAMA, Naohiro
nkoriyama at gmail.com