[vlc-devel] [PATCH] Fix stack overflow in ExecuteCommand

Rémi Denis-Courmont remi at remlab.net
Thu Dec 15 18:38:26 CET 2011


Le jeudi 15 décembre 2011 19:14:42 Cheng Sun, vous avez écrit :
> Fix ticket #5675
> 
> Because ExecuteCommand allocates temporary string space on the stack,
> proportional to the length of the command to execute, a stack overflow can
> occur when the the command is too long.

With this patch, VLC will do undefined behaviour as in dereferencing NULL 
instead of undefined behaviour as in overflowing the stack.

It could be better...

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list