[vlc-devel] [PATCH] yadif : Add SSSE3 and SSE2 support. porting from FFmpeg.

Jean-Baptiste Kempf jb at videolan.org
Wed Dec 21 02:25:24 CET 2011


On Tue, Dec 20, 2011 at 08:08:46PM +0900, Naohiro KORIYAMA wrote :
> With a patch, I sent 3 days ago, inline assembler part of code may not
> be compiled on some environment.
> Attached patch fixed the issue.

I have:


CC     libdeinterlace_plugin_la-algo_yadif.lo
In file included from ../../../modules/video_filter/deinterlace/yadif.h:49:0,
                 from ../../../modules/video_filter/deinterlace/algo_yadif.c:48:
../../../modules/video_filter/deinterlace/yadif_template.h: In function 'yadif_filter_line_ssse3':
../../../modules/video_filter/deinterlace/yadif_template.h:114:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
../../../modules/video_filter/deinterlace/yadif_template.h:114:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
In file included from ../../../modules/video_filter/deinterlace/yadif.h:64:0,
                 from ../../../modules/video_filter/deinterlace/algo_yadif.c:48:
../../../modules/video_filter/deinterlace/yadif_template.h: In function 'yadif_filter_line_sse2':
../../../modules/video_filter/deinterlace/yadif_template.h:114:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
../../../modules/video_filter/deinterlace/yadif_template.h:114:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
In file included from ../../../modules/video_filter/deinterlace/yadif.h:77:0,
                 from ../../../modules/video_filter/deinterlace/algo_yadif.c:48:
../../../modules/video_filter/deinterlace/yadif_template.h: In function 'yadif_filter_line_mmx':
../../../modules/video_filter/deinterlace/yadif_template.h:114:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
../../../modules/video_filter/deinterlace/yadif_template.h:114:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Expected?

> sorry for sending modification many times.

Please, do not excuse yourself for improving a patch.
People should excuse themselves when they don't answer to a review, not the opposite :D

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list