[vlc-devel] [PATCH] yadif : Add SSSE3 and SSE2 support. porting from FFmpeg.

[Naohiro KORIYAMA]

2011/12/21 Naohiro KORIYAMA <nkoriyama at gmail.com>:
> 2011/12/21 Jean-Baptiste Kempf <jb at videolan.org>:
>> On Tue, Dec 20, 2011 at 08:08:46PM +0900, Naohiro KORIYAMA wrote :
>>> With a patch, I sent 3 days ago, inline assembler part of code may not
>>> be compiled on some environment.
>>> Attached patch fixed the issue.
>>
>> I have:
>>
>>
>> CC     libdeinterlace_plugin_la-algo_yadif.lo
>> In file included from ../../../modules/video_filter/deinterlace/yadif.h:49:0,
>>                 from ../../../modules/video_filter/deinterlace/algo_yadif.c:48:
>> ../../../modules/video_filter/deinterlace/yadif_template.h: In function 'yadif_filter_line_ssse3':
>> ../../../modules/video_filter/deinterlace/yadif_template.h:114:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> ../../../modules/video_filter/deinterlace/yadif_template.h:114:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> In file included from ../../../modules/video_filter/deinterlace/yadif.h:64:0,
>>                 from ../../../modules/video_filter/deinterlace/algo_yadif.c:48:
>> ../../../modules/video_filter/deinterlace/yadif_template.h: In function 'yadif_filter_line_sse2':
>> ../../../modules/video_filter/deinterlace/yadif_template.h:114:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> ../../../modules/video_filter/deinterlace/yadif_template.h:114:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> In file included from ../../../modules/video_filter/deinterlace/yadif.h:77:0,
>>                 from ../../../modules/video_filter/deinterlace/algo_yadif.c:48:
>> ../../../modules/video_filter/deinterlace/yadif_template.h: In function 'yadif_filter_line_mmx':
>> ../../../modules/video_filter/deinterlace/yadif_template.h:114:32: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>> ../../../modules/video_filter/deinterlace/yadif_template.h:114:20: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>>
>> Expected?
>
> According to http://ffmpeg.org/trac/ffmpeg/ticket/25 and
> http://patches.libav.org/patch/2444/, this is a hack for MS Visual
> C++.
> And it isn't necessary for VLC, I think.
>
> Here is another patch for the warning. I compiled it on Linux 64 bit
> gcc,  Mac OS X 64biy clang, gcc and Windows 32 bit gcc.

I forget the attachment...

-- 
KORIYAMA, Naohiro
nkoriyama at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-yadif-Add-SSSE3-and-SSE2-support.-porting-from-FFmpe.patch
Type: application/octet-stream
Size: 30300 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111221/3e8a9750/attachment.obj>