[vlc-devel] [PATCH] stream_filter/decomp.c: fix Read function

Frederic YHUEL fyhuel at viotech.net
Wed Dec 28 15:57:24 CET 2011


>>
>> PS: This patch is not tested, because I've no idea about how to test
>> it... but it seems trivial enough :-)
>
> I am not applying untested patches because (other) people have abused this far
> too much far too recently.
>

Ok, I understand. I'll find a way to test it.

>> Actually I was reading this code to try and understand what *exactly*
>> the Peek function is supposed to do in a stream_filter module.
>>
>> So now it's clear, but seriously, this is not trivial. For example,
>> you could be mislead (as I did) by the Peek function of decomp.c if
>> you don't read also the Read function of the same file.
>
> I don't think anybody disagrees. Nobody has bothered to simplify the interface
> though. And it gets harder and harder as more plugins get added.
>

Ok. At least it's not just me, it's reassuring :-)

-- 
Frédéric



More information about the vlc-devel mailing list