[vlc-devel] [PATCH] Qt4: Enable tabs in sout dialog

[Rafaël Carré]

Le 2011-12-29 15:12, Edward Wang a écrit :
> On 11-12-29 03:10 PM, Rafaël Carré wrote:
>> Le 2011-12-29 15:08, Edward Wang a écrit :
>>> This patch will enable tabs in the sout dialog if possible (given the right Qt version).
>>> Thanks,
>>> @@ -163,6 +165,7 @@ void SoutDialog::addDest( )
>>>               break;
>>>           default:
>>>               assert(0);
>>> +            return;
>>>       }
>>>
>>>       int index = ui.destTab->addTab( db, caption );
>> Looks unrelated to the patch
>>
> Well, it prevents a warning about use of an uninitialised variable (db). 
> It can be removed if really bothers you that much.

I am not sure if it really fixes that warning.

Anyway you should have mentioned it in the commit log or made 2 patches;
and I think you should just remove it