[vlc-devel] [PATCH] Qt4: Enable tabs in sout dialog

[Jean-Baptiste Kempf]

On Thu, Dec 29, 2011 at 05:45:01PM -0500, Edward Wang wrote :
> +#include <QtGlobal>

No need.

> -#if 0
> +#if QT_VERSION >= 0x040500

Useless, we use already 4.6

> -                      PLAYLIST_END, pl, pl_Unlocked );
> +                      3, pl, pl_Unlocked );

Why?

> +class QVLCTabWidget : public QTabWidget
> +{
> +    Q_OBJECT
> +public:
> +    QVLCTabWidget() : QTabWidget() {};
> +    QVLCTabWidget( QWidget* parent )
> +    : QTabWidget(parent) {
> +
> +    }
> +    QTabBar* getTabBar() { return tabBar(); };
> +};

A new class, just for a getter, used only once?

Why not using something simpler, like QObject::findChild ?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device