[vlc-devel] [PATCH] Change to npapi for giving access to media meta thru new input.meta(i) method.

[jean-michel Lambert]

Regarding the way to expose the meta info, do you prefer me to add a 
property "meta" and sub properties for each meta type  (ie 
input.meta.title, meta.currentlyPlaying, etc ... ?). I liked it this way 
before it allows to process new fields in the future without recompiling 
everything.

thanks,

On 30/12/2011 02:21, Jean-Baptiste Kempf wrote:
> On Wed, Dec 28, 2011 at 11:41:54PM +0100, JM Lambert wrote :
>> +
> Why?
>
>> +
>> +
> Idem?
>
>> -    "none",
>> +    "meta",
> That doesn't break anything? Instead of adding it?
>
>
>> +        VlcPlugin* p_plugin = getPrivate<VlcPlugin>();
>> +        libvlc_media_player_t *p_md = p_plugin->getMD();
>> +	libvlc_media_t * p_media = libvlc_media_player_get_media(p_md);
> No tabs.
> If p_md was NULL, wouldn't this be bad?
>
>> +        if( !p_md )
>> +            RETURN_ON_ERROR;
>>           switch( index )
>>           {
>> -            case ID_none:
>> -                return INVOKERESULT_NO_SUCH_METHOD;
>> +            case ID_input_meta:
>> +		if( argCount == 1)
> tabs
>
>> +                {
>> +                    char *info;
> const?
>
>> +                    int i_metaID,  i;
> i is used?
>
> Btw, is this the best way to expose this API?
>
> Best regards,
>