[vlc-devel] [PATCH] Win32: revert to old rc interface

[Pierre Ynard]

See #4455. The lua interface merely polls, reads and writes on file
descriptors 0 and 1, and expects it to work. There is no support for
spawning a console and redirecting/getting file descriptors to it, and
file descriptors are mixed with socket descriptors and polled, which
won't work on windows. Unless somebody steps up to fix this, we should
revert to the old rc interface.


diff --git a/modules/control/rc.c b/modules/control/rc.c
index 0580a5d..b60c896 100644
--- a/modules/control/rc.c
+++ b/modules/control/rc.c
@@ -201,6 +201,9 @@ vlc_module_begin ()
     set_capability( "interface", 20 )
 
     set_callbacks( Activate, Deactivate )
+#ifdef WIN32
+    add_shortcut( "rc" )
+#endif
 vlc_module_end ()
 
 /*****************************************************************************
diff --git a/modules/misc/lua/intf.c b/modules/misc/lua/intf.c
index 3fea273..6b283a4 100644
--- a/modules/misc/lua/intf.c
+++ b/modules/misc/lua/intf.c
@@ -71,7 +71,9 @@ static const struct
     const char *psz_name;
 } pp_shortcuts[] = {
     { "luarc", "rc" },
+#ifndef WIN32
     { "rc", "rc" },
+#endif
     { "luahotkeys", "hotkeys" },
     /* { "hotkeys", "hotkeys" }, */
     { "luatelnet", "telnet" },
diff --git a/modules/misc/lua/vlc.c b/modules/misc/lua/vlc.c
index 52dc54a..4056ff3 100644
--- a/modules/misc/lua/vlc.c
+++ b/modules/misc/lua/vlc.c
@@ -144,7 +144,9 @@ vlc_module_begin ()
     add_submodule ()
         set_description( N_("Lua Interface Module (shortcuts)") )
         add_shortcut( "luarc" )
+#ifndef WIN32
         add_shortcut( "rc" )
+#endif
         set_capability( "interface", 25 )
         set_callbacks( Open_LuaIntf, Close_LuaIntf )
 
---

Regards,

-- 
Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."