[vlc-devel] please check about es_out.c

Laurent Aimar fenrir at elivagar.org
Thu Feb 3 20:45:27 CET 2011


On Thu, Feb 03, 2011 at 10:39:06PM +0900, 김정은 wrote:
> Hi.
> 
> Please check about /src/input/es_out.c
> 
> LineNo 2743.
> 
> if( *pl->psz_native_name ) <--- this is not right.
> {
> return strdup( pl->psz_native_name );
> }
> return strdup( pl->psz_eng_name ); <--- it need check about null.
 All our iso639_lang_t entries have non NULL psz_native_name and psz_eng_name
fields, so testing for NULL is not needed.
 The check on *pl->psz_native_name is the wanted one, when there isn't any
native name defined, it is an empty string, for which we fallback to the 
english name.

Regards,

-- 
fenrir




More information about the vlc-devel mailing list