[vlc-devel] [PATCH 2/9] dbus: Rework the main loop using a poll() based model

[Mirsal Ennaime]

Hi Remi,

On Tue, 2011-02-08 at 23:46 +0200, Rémi Denis-Courmont wrote:
> Le mardi 8 février 2011 23:35:57 Mirsal Ennaime, vous avez écrit :
> > From: Mirsal Ennaime <mirsal.ennaime at gmail.com>

[...]

> > +    dbus_threads_init_default();
> > +
> 
> Missing error check?

Indeed, thanks.

> >      p_sys->b_meta_read = false;
> >      p_sys->i_caps = CAPS_NONE;
> >      p_sys->b_dead = false;
> >      p_sys->p_input = NULL;
> >      p_sys->i_playing_state = -1;
> > 
> > +    if( pipe( &p_sys->i_pipe_fd_out ) )
> 
> We have vlc_pipe() for this.

OK, I didn't know about this one :)

> > +    if( !dbus_connection_set_watch_functions( p_conn,
> > +                                              add_watch,
> > +                                              remove_watch,
> > +                                              watch_toggled,
> > +                                              p_intf, NULL ) )
> > +    {
> > +        dbus_connection_set_dispatch_status_function( p_conn,
> > +                                                      NULL, NULL, NULL );
> > +        dbus_connection_set_timeout_functions( p_conn,
> > +                                               NULL, NULL, NULL, NULL,
> > NULL );
> 
> What's that for??

Ah, it is indeed useless, as the "free_data_function" argument is not
used here.

Thank you very much for your insight,
I'll fix these asap.

Best regards,

-- 
mirsal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110208/64e14820/attachment.sig>