[vlc-devel] [PATCH] Soft field repeat support for deinterlacer

[Rémi Denis-Courmont]

   Hello,

On Thu, 10 Feb 2011 13:55:29 +0200, Juha Jeronen <juha.jeronen at jyu.fi>
wrote:
> I agree. If the latest IVTC is included, this file will balloon to
> something like 4500 lines.
> 
> But before I do anything drastic, I'd like to hear Laurent's comments on
> the issue, too :)
> 
> 
> Based on what I currently know about VLC's deinterlacer, I would
> tentatively suggest the following split:

Hmm, first it probably needs its own subdirectory in video_filter. We don't
need to add a new Makefile though.

> - Consider deinterlace.c as the main source file for the deinterlacer
> subsystem. Keep Deinterlace(), Open(), Flush(), Close(),
> SetFilterMethod(), GetOutputFormat() etc. general stuff in that one.

Obviously.

> - filter_sys_t: this definition needs to be seen by all parts of the
> deinterlacer. Move to header?

Unavoidable to some extent, yes. Then again, algorithms could have their
own data allocated in private structures on the fly.

> - Simple rendering algorithms with just one function, or maybe two
> functions at most: make a new file that gathers these.

Is there even such an algorithm? Typically the simpler algorithm have the
most variants of SIMD inline assembler.

> - More complex rendering algorithms with lots of helper functions (e.g.
> X) or private data (e.g. the upcoming IVTC): one file per algorithm.

Yes.

> - Maybe one file for common helper functions? I have such a case coming
> up: both IVTC and Phosphor need ComposeFrame().

No opinion.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis