[vlc-devel] [PATCH] Soft field repeat support for deinterlacer

[Jean-Baptiste Kempf]

On Thu, Feb 10, 2011 at 01:55:29PM +0200, Juha Jeronen wrote :
> Based on what I currently know about VLC's deinterlacer, I would
> tentatively suggest the following split:
Yes.

> - Consider deinterlace.c as the main source file for the deinterlacer
> subsystem. Keep Deinterlace(), Open(), Flush(), Close(),
> SetFilterMethod(), GetOutputFormat() etc. general stuff in that one.
Yes.

> - filter_sys_t: this definition needs to be seen by all parts of the
> deinterlacer. Move to header?
Probably, yes.

> - Simple rendering algorithms with just one function, or maybe two
> functions at most: make a new file that gathers these.
Yes. What the core deinterlace.c was.

> - More complex rendering algorithms with lots of helper functions (e.g.
> X) or private data (e.g. the upcoming IVTC): one file per algorithm.
Like yadif, yes.

> - Maybe one file for common helper functions? I have such a case coming
> up: both IVTC and Phosphor need ComposeFrame().

Maybe this is overkill.


However, I would propose to split AFTER the commits of the IVTC (and
phosphor)


And I would also suggest that you resend a clean batch for the IVTC and
Phosphor filters.


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734