[vlc-devel] [PATCH] For MacOS X to support capture devices other than iSight

[Katsushi Kobayashi]

Hi, 

I have never read and never taken care the coding rule of  VLC developer :).
This is a just reason of my messy codes. Also, I misunderstood NSLog() is
acceptable, since I found some NSLog() in qtcapture.m.

Regards,

----
Katsushi Kobayashi




On 2011/02/11, at 21:05, Jean-Baptiste Kempf wrote:

> 
> Hello Katsushi,
> 
> On Fri, Feb 11, 2011 at 05:28:20PM +0900, Katsushi Kobayashi wrote :
>> This is a quick patch for VLC.app for MacOS X. VLC.app will support additional
>> capture device compliant to QTKit. This patch requires to add QTKit library, when
>> building macosx-gui module. I couldn't find out how to add the additional library
>> in generic source tree, since I am a novice of VLC develop.
> 
> Thanks for your code.
> 
> However, you should send one patch for qtcapture.m first, in a git
> formatted way. And then another one for the UI.
> 
>> diff --git a/modules/access/qtcapture.m b/modules/access/qtcapture.m
>> index f6665eb..a64098b 100644
>> --- a/modules/access/qtcapture.m
>> +++ b/modules/access/qtcapture.m
>> @@ -36,10 +36,14 @@
>> #include <vlc_demux.h>
>> #include <vlc_interface.h>
>> #include <vlc_dialog.h>
>> +#include <vlc_access.h>
>> +#include <vlc_variables.h>
> 
> Do you need vlc_variables.h ?
> 
>> +		if(imageBuffer){
> No tabs in source code!
> Please conform to the coding style of the file you are modifying.
> 
>> -    int chroma = qtchroma_to_fourcc( qtchroma );
>> +#if 0
>> +	int chroma = qtchroma_to_fourcc( qtchroma );
> 
> Why?
> 
>> +#if 0
>> #define setEyeTVUnconnected ¥
>> [o_capture_lbl setStringValue: _NS("No device connected")]; ¥
>> [o_capture_long_lbl setStringValue: _NS("VLC could not detect any EyeTV compatible device.¥n¥nCheck the device's connection, make sure that the latest EyeTV software is installed and try again.")]; ¥
>> [o_capture_lbl displayIfNeeded]; ¥
>> [o_capture_long_lbl displayIfNeeded]; ¥
>> [self showCaptureView: o_capture_label_view]
>> +#else
>> +NSArray               *qtkvideoDevices;
>> +#define setEyeTVUnconnected ¥
> Why again?
> 
> I don't see why using NSlog over msg_Dbg ?
> 
> Best Regards,
> 
> -- 
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> +33 672 704 734