[vlc-devel] [PATCH] Fix bug in taglib txxx handling

Jean-Baptiste Kempf jb at videolan.org
Tue Feb 15 23:46:35 CET 2011


On Tue, Feb 15, 2011 at 11:07:51PM +0200, Rémi Denis-Courmont wrote :
> Le mercredi 9 février 2011 15:23:25 Johannes Weißl, vous avez écrit :
> > Currently, vlc puts the value *and* the description in the value field
> > for id3 TXXX tags, e.g. in Media Information:
> > REPLAYGAIN_TRACK_GAIN: REPLAYGAIN_TRACK_GAIN +3.30 dB
> > 
> > This leads to vlc_audio_replay_gain_MergeFromMeta() failing because it
> > can't parse the floating point value. Since the fieldList() of an
> > UserTextIdentificationFrame has exactly two members, it is safe to just
> > use the last (value) member. In Media Information:
> > REPLAYGAIN_TRACK_GAIN: +3.30 dB
> > 
> > This makes ReplayGain work for mp3 files.
> 
> Merged, thanks.

And backported.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734



More information about the vlc-devel mailing list