[vlc-devel] [PATCH] Fix bug in taglib txxx handling

Rémi Denis-Courmont remi at remlab.net
Wed Feb 16 08:54:56 CET 2011


On Wed, 9 Feb 2011 14:29:07 +0100, Johannes Weißl <jargon at molb.org> wrote:
> On Wed, Feb 09, 2011 at 02:23:25PM +0100, Johannes Weißl wrote:
>> This makes ReplayGain work for mp3 files.
> 
> This is not true in all cases: foobar2000 writes ReplayGain tags in
> lowercase (replaygain_track_gain), which VLC doesn't recognize.
> 
> What would be the best way to fix that?
> 1. Store extra tags all in lowercase / uppercase [vlc_meta_AddExtra()]
> 2. Get extra tags case insensitive [vlc_meta_GetExtra()]
> 3. Just get ReplayGain extra tags case insensitive
>    [vlc_audio_replay_gain_MergeFromMeta()]

I don't really care. I suppose there are no use case for semantically
different tags using the same spelling but different case.

-- 
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis




More information about the vlc-devel mailing list