[vlc-devel] Deinterlacer TODO proposal / JJ

[Juha Jeronen]

Hi,

On 02/18/11 12:48, Jean-Baptiste Kempf wrote:
>
> On Fri, Feb 18, 2011 at 02:01:18AM +0200, Juha Jeronen wrote :
>> 0) Split the private_picture buffer increase into a separate patch. (Work estimate: a few minutes)
>
>> 1) Fix the soft field repeat / repeat_pict patch (Laurent's review + my own observations). Aiming to make this the final round of changes for this patch. (Work estimate: 1-2 h)
>
>> 2) Refactor the input frame history mechanism. The exact same history mechanism that was originally developed for RenderYadif() will be needed by IVTC and Phosphor, so it makes sense to refactor it first. (Work estimate: 1-2 h)
>
>> 3) Rework IVTC. (Work estimate: 1-2 days)
>
>> 4) Update Phosphor. (Work estimate: 1-2 h)
>>
>> 5) Split the deinterlacer subsystem sensibly into separate files.
>>      - Make a subdirectory (in video_filter), move deinterlace.c there
>>      - Update existing Makefile
>
> Modules.am you mean :D

Ah, yes. I was going to ask later about the correct way to do this. 
Thanks :)


>>      - Keep general stuff in deinterlace.c
>>      - Keep general-use data in filter_sys_t
>>      - Move filter_sys_t to header
>>      - Move each algorithm into its own file
>>      - Move private data into private structs; add init/uninit API
>>      - Make a file for general-use helper functions
>>          - ComposeFrame()
>>          - Motion detector
>>          - Blend routines?
>>      - Test that nothing broke ;)
>>      - Format patch, post.
>
>   - use enums instead of defines for the deinterlacer lists.

Sounds good. Let's add that.


> 6) ...
> 7) Profit!

Mm, the essential steps in any plan.


> Anyway, that sound like awesome to me.

Ok :)


  -J