[vlc-devel] First patch

Mirsal Ennaime mirsal at mirsal.fr
Tue Feb 22 15:31:30 CET 2011


On Tue, 2011-02-22 at 13:40 +0100, Andri Pálsson wrote:
> This is just a patch to fix one compiler warning.

I applied your patch, but it is actually wrong, because:

<j-b> if size > MAX_INT
<j-b> blooum

So the offending line now reads:
(And it might not be correct neither)

if ((uint8_t)(end - current) < size)

> I just wanted to test the whole procedure from end to end.

You might also want to use a more meaningful subject header
(with git send-email or by reusing the first line of your commit log)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110222/b44d0975/attachment.sig>

More information about the vlc-devel mailing list