[vlc-devel] [PATCH] Phosphor deinterlacer, reworked

[Juha Jeronen]

On 02/23/11 13:22, Jean-Baptiste Kempf wrote:
> On Wed, Feb 23, 2011 at 12:39:35PM +0200, Juha Jeronen wrote :
>> I'm not sure I understand? Obviously, it's currently a compile-time
>> option... did you mean, why propose it as an option at all? Or why not
>> propose it as a runtime option?
>
> Why not proposing as a runtime option.

Ok.

>> For the second one - any pointers on how to do that? Currently none of
>> the deinterlacers have any runtime options, so there was no example. (I
>> think that's pretty neat - since they have nothing to configure, they
>> have to be designed carefully, and also are easier to use. The "no
>> options" approach is not always reasonable, but for deinterlacers I
>> think it should work - at least for the most part, hence the current
>> confusion.)
>
> After the vlc_module_begin () declaration, use add_bool( ... ), like in
> puzzle.c
> Then use it in the code with var_Inherit...

Thanks! I'll take a look at puzzle.c, then :)

> Yes, no option is better, sure. But here, it avoids recompilation to get
> a new mode. And if it is an obscure option, it will not  bother users,
> as long as the default is the sane one.

Ok. Good points. I agree :)

I'll fix the patch and repost tonight.

  -J