[vlc-devel] [GCI] last.fm access module

Jakub Wieczorek fawek at fawek.net
Sun Jan 2 22:23:59 CET 2011


2011/1/2 Rémi Denis-Courmont <remi at remlab.net>:
> Le samedi 1 janvier 2011 03:05:02 Jakub Wieczorek, vous avez écrit :
>> Hello,
>>
>> As a GCI task I've been working on an access module for last.fm radio
>> stations. It's now reached the stage of being usable and I'd like to
>> gather some feedback.
>
> The way you use vlc_cancel() will leak and/or leave inconsistent lots of
> stuff.

You're right, thanks. Attaching a revised patch and a diff against the
previous one.

Best regards,
Jakub Wieczorek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-an-access-module-that-works-with-last.fm-radio-s.patch
Type: text/x-patch
Size: 42584 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110102/76494e53/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Disable-cancellation-for-the-helper-thread-when-pull.patch
Type: text/x-patch
Size: 1346 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110102/76494e53/attachment-0001.bin>


More information about the vlc-devel mailing list