[vlc-devel] [PATCH] This patch gives VLC users the option of enabling / disabling changes to its icon

[Rémi Denis-Courmont]

Le mardi 4 janvier 2011 00:47:20 sovereign at codefaction.net, vous avez écrit :
> diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> index 6701889..70e0a24 100644
> --- a/src/libvlc-module.c
> +++ b/src/libvlc-module.c
> @@ -1228,6 +1228,11 @@ static const char *const ppsz_clock_descriptions[] =
>      "When using the one instance only option, enqueue items to playlist "
> \ "and keep playing current item.")
> 
> +#define WINTERJOKE_TEXT N_( \
> +    "Allow VLC To Change Its ICON")

Too much upper case.

> +#define WINTERJOKE_LONGTEXT N_( \
> +    "This option allows VLC to change its icon during various
> occassions.") +
>  /*************************************************************************
> **** * Playlist
>  
> **************************************************************************
> **/ @@ -2119,6 +2124,8 @@ vlc_module_begin ()
>                ONEINSTANCEWHENSTARTEDFROMFILE_LONGTEXT, true )
>      add_bool( "playlist-enqueue", 0, PLAYLISTENQUEUE_TEXT,
>                PLAYLISTENQUEUE_LONGTEXT, true )
> +    add_bool( "qt-winter-joke", 1, WINTERJOKE_TEXT,
> +              WINTERJOKE_LONGTEXT, true )

A more generic option name would probably not hurt if more icon variants are 
added.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis