[vlc-devel] [PATCH] Qt/ML: New Models for Playlist UI

[Srikanth Raju]

Hi,

I plan to merge these by Sunday.

>
>> Subject: [PATCH 2/3] Qt/ML: ML Model and Item
>
>> +        case ML_TYPE:
> What is ML_TYPE used for?
>
Nothing, for now.

>> +        case ML_TITLE:
>> +        {
>> +            /* If no title, return filename */
>> +            if( media->psz_title && *media->psz_title )
>> +                return qfu( media->psz_title );
> I believe this should be merged with other functions that do mostly the
> same, in the future.
>
Can't really do anything except macro it.

>
>> +bool MLModel::popup( const QModelIndex & index, const QPoint &point, const QModelIndexList &list )
> Why is that not in VLCModel?
>
> And a few other linked to popup too?
>
It's there. I could also virtualize popupDel() popupAdd() etc, but
those are specific to the models and get called by popup(). It's
better to just have only the necessary interfaces in VLCModel instead
of pulling everything out that can be pulled out.


-- 
Regards,
Srikanth Raju
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Qt-ML-VLC-Model.patch
Type: text/x-patch
Size: 6022 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110108/a9357b6d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Qt-ML-ML-Model-and-Item.patch
Type: text/x-patch
Size: 42900 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110108/a9357b6d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Qt-ML-Extend-Playlist-model-from-VLCModel.patch
Type: text/x-patch
Size: 7039 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110108/a9357b6d/attachment-0002.bin>