[vlc-devel] [GCI] last.fm access module

Jakub Wieczorek fawek at fawek.net
Sat Jan 8 14:18:14 CET 2011


2011/1/8 Rémi Denis-Courmont <remi at remlab.net>:
> Le samedi 8 janvier 2011 01:22:37 Jakub Wieczorek, vous avez écrit :
>> Any update on this? Is it ready to go in?
>  - b_error is not protected correctly.

Yes, that's intentional. To protect this correctly I'd have to do a
mutex lock/unlock on each Read() invocation, which may harm
performance, to the best of my knowledge. And I'm also under the
impression a boolean datum doesn't need to be protected in certain
cases such as this one. Please let me know if I'm mistaken.

>  - the mutex seems leaked on cancellation

Right. I guess that's what mutex_cleanup_push is for? I'll take a look. Thanks.

Best regards,
Jakub Wieczorek

More information about the vlc-devel mailing list