[vlc-devel] [PATCH 3/4] Symbian Specific initialization Routines Including ThreadController

[Jean-Baptiste Kempf]

On Sun, Jan 09, 2011 at 01:33:51AM +0530, Pankaj yadav wrote :
> +extern "C"
Needed?

> +static int ret;
needed?

> +    drive[0]=*letter;
> +    drive[1]=':';drive[2]='\\';drive[3]='s';drive[4]='y';
> +    drive[5]='s';drive[6]='\\';drive[7]='b';drive[8]='i';
> +    drive[9]='n';drive[10]='\0';
can't you write that more elegantly?

> +    pthread_once_t once = PTHREAD_ONCE_INIT;
> +    ret=pthread_create(&threadid,NULL,ThreadController,&dead);
> +    pthread_once (&once, set_libvlc_path);
> +    (void)libvlc; (void)argc; (void)argv;
Style, please.

> +{
> +    (void)libvlc; (void)argc; (void)argv;
Use VLC_UNUSED, please.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734