[vlc-devel] [PATCH 2/2] YADIF : Code the instruction width into 'cmp'.

Jai Menon jmenon86 at gmail.com
Mon Jan 10 22:26:59 CET 2011


On Sun, Jan 9, 2011 at 11:36 AM, Jai Menon <jmenon86 at gmail.com> wrote:
> Without this, clang will complain about the asm block.
> ---
>  modules/video_filter/yadif.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/modules/video_filter/yadif.h b/modules/video_filter/yadif.h
> index 2d2a56f..260fa65 100644
> --- a/modules/video_filter/yadif.h
> +++ b/modules/video_filter/yadif.h
> @@ -154,7 +154,7 @@ static void yadif_filter_line_mmx2(struct vf_priv_s *p, uint8_t *dst, uint8_t *p
>  \
>             /* if(p->mode<2) ... */\
>             "movq    %[tmp3], %%mm6 \n\t" /* diff */\
> -            "cmp       $2, %[mode] \n\t"\
> +            "cmpl       $2, %[mode] \n\t"\
>             "jge       1f \n\t"\
>             LOAD4("(%["prev2"],%[mrefs],2)", %%mm2) /* prev2[x-2*refs] */\
>             LOAD4("(%["next2"],%[mrefs],2)", %%mm4) /* next2[x-2*refs] */\

Could someone please apply this, it's a trivial change and moves us a
step closer to being able to build with clang.
Thanks.

-- 
Jai Menon



More information about the vlc-devel mailing list