[vlc-devel] [PATCH] Add Dirac encoding support to VLC using the Schroedinger library.

[Anuradha Suraparaju]

Hi,

Attached two new patches to this email.

Patch 1 - Dirac encoding using Schroedinger library
Patch 2 - Using Schro encoder settings utilities to fetch and set encoding
options rather than
              hardcoding the names in the Schro plugin module.


I am off on holiday from Friday to  the end of the Jan. I can make any minor
changes suggested before Fri.

Regards,
Anuradha

On Mon, Dec 20, 2010 at 10:42 AM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> Hello,
>
> On Mon, Dec 20, 2010 at 10:13:50AM +1100, Anuradha Suraparaju wrote :
> > There are many Schro encoder options that an end user will probably never
> > ever use. So the number of options will be really long. In order to set
> an
> > option as advanced, we might probably have to parse the option names to
> > determine whether it is is an advanced option e.g. all the magic_*
> encoder
> > options.
> OK.
>

Implemented in Patch 2.

>
> > - "Schro has a mechanism for passing PTS through the encoder, with
> > > schro_encoder_push_full()
> > >   so StorePicturePTS() and friends is not useful."
> > >
> > will do this. I already used this call in another piece of software I
> wrote
> > ages ago. I was trying to keep the Schro plugin as similar to the dirac
> > plugin as possible.
>
> Ok. But I think that even if the dirac similarity is nice, we should
> always try the best way, especially since the dirac plugin will die.
>
> > > - "schro_video_format_set_std_video_format() should be called
> > >  with SCHRO_VIDEO_FORMAT_CUSTOM rather than guessing a value -- CUSTOM
> > >  causes the encoder to guess a better value
> > >
> > As far as I know this is not true. CUSTOM means just that - the user
> needs
> > to customise the different video format parameters. Schro encoder does
> not
> > customise the encoder parameters if the video format is set to CUSTOM.
>
> Well, that was told by some schroedinger developers, so well...
>
>
> > - "Should call schro_encoder_set_packet_assembly (schro_enc->encoder,
> TRUE);
> > > instead of
> > >   assembling packets manually"
> > >
> > >
> > Will do this. Again, I used this call in another plugin I wrote.
> ok.
>
>
Implemented in Patch 1.


> > I guess it will be best if I send two patches. One patch covering the PTS
> > and assembling packets part with the options parsing code the same as it
> is
> > in the patch I sent earlier.
> >
> > The second patch will contain the changes to the options parsing code
> using
> > the schro encoder options setting API.
> >
> > How does this sound?
> It seems the first patch is needed. It should probably be merged with
> the main one.
>
> I have no opinion about the necessity of the second one.
>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/
> +33 672 704 734
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110111/40e6c2e6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Add-Dirac-encoding-support-to-VLC-using-the-Schroedi.patch
Type: text/x-patch
Size: 46278 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110111/40e6c2e6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Use-Schro-encoder-settings-utility-functions-to-fetc.patch
Type: text/x-patch
Size: 31271 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110111/40e6c2e6/attachment-0001.bin>