[vlc-devel] [PATCH 5/6] Libvlc Thread Backend for Symbian

[Jean-Baptiste Kempf]

On Wed, Jan 19, 2011 at 01:15:13AM +0530, Pankaj yadav wrote :
> +        symbian\thread.cpp \
No.

> +#include <stdarg.h>
> +#include <assert.h>
> +#include <limits.h>
> +#include <errno.h>
> +#include <sys/socket.h>
> +#include <unistd.h>
> +#include <sys/wait.h>
> +#include <sys/fcntl.h>
> +#include <sys/socket.h>
> +#include <time.h>
> +#include <pthread.h>
> +#include <sys/select.h>
> +#include <semaphore.h>
You really need all of those?

> +typedef struct thread_db thread_db;
merge that with under declaration, if you really need it.

> +typedef struct threadentry threadentry;
idem.

> +                    for (vlc_cleanup_t *p = p_operand->cleaners; p != NULL; p = p->next){p->proc (p->data);}/*CleanUp*/
ahem...

> +                if(parent == NULL)
> +                {
> +                p_thread_db = p_operand->next;
> +                }
> +                else
> +                {
> +                parent->next = p_operand->next;
> +                free( p_operand );
> +                }
Indentation

> +                if(!locked){vlc_mutex_unlock(&threadcontroller);}
codestyle

> +            if(p_operand->next == NULL){break;}
idem

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/
+33 672 704 734