[vlc-devel] [PATCH] MacOS GUI: Tie display fade to "Black out" preference

Ron Frederick ronf at timeheart.net
Sun Jul 10 01:02:36 CEST 2011


Last year, I submitted a patch to this list for an issue I had with the MacOS GUI, related to running VLC on a Mac with multiple displays. I know that the old MacOS GUI is not being officially maintained any more and that development is now focused on Lunettes, but for now Lunettes still doesn't do everything that the original VLC app does on the Mac, and in the meantime I'd really like to get this patch merged into the current VLC if possible.

I've revised my patch for the latest VLC master branch, and also have a version of it intended for the vlc-1.1 branch if that would work better. The patch is very simple, and other than line numbers it is effectively the same between the two branches.

Basically, whenever VLC enters or leaves full-screen mode, it always causes all of the displays on the system (not just the one entering full screen) to fade down to black momentarily. There's a setting for whether displays other than the one playing the video will be blacked out during playback and these other displays will turn back on after the fade when that setting is disabled, but having them fade to black both at the start and at the end of playback when they aren't going to be blacked out has never really made sense to me.

My patch causes the fade to be tied to whether VLC is set to black out these other displays or not. If it is, the fade will behave just as it does now. However, when this setting is disabled, the fade will no longer occur. The display going to full screen mode starts and stops playing the video as before but the other displays are not affected.

I'd really appreciate it if you would consider this for inclusion into the VLC sources. Thanks for listening!

Ron Frederick
ronf at timeheart.net

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110709/a5066aab/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-MacOS-GUI-Tie-display-fade-to-Black-out-preference.patch
Type: application/octet-stream
Size: 3398 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110709/a5066aab/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110709/a5066aab/attachment-0001.html>

More information about the vlc-devel mailing list