[vlc-devel] [vlc-commits] Remove useless vlc_object parameter when creating an input item

[Felix Paul Kühne]

Hello,

On 10.07.2011, at 19:12, Rémi Denis-Courmont wrote:

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Jul 10 18:23:41 2011 +0300| [629dbd8af1ac2b65b3cc9477616c9c8ae4c2e7af] | committer: Rémi Denis-Courmont
> 
> Remove useless vlc_object parameter when creating an input item

This commit breaks the execution of VLC for me, since it triggers a crash on launch due to a failed mutex lock:

LibVLC fatal error locking mutex (22) in thread 140735083547840 at ../../src/posix/thread.c:239 in vlc_mutex_lock
#0  0x00007fff863e00b6 in __kill ()
#1  0x00007fff864809f6 in abort ()
#2  0x0000000100098d39 in vlc_thread_fatal () at thread.c:141
#3  0x0000000100042dc9 in input_item_SetName [inlined] () at /Users/fpk/Desktop/videolan/vlc/src/input/item.c:311
#4  0x0000000100042dc9 in input_item_NewWithType (psz_uri=0x0, psz_name=0x1000bc520 "Undefined", i_options=0, ppsz_options=0x0, flags=0, duration=-1, type=<value temporarily unavailable, due to optimizations>) at item.c:823
#5  0x000000010003dcb3 in playlist_NodeCreate (p_playlist=0x10022c9a8, psz_name=<value temporarily unavailable, due to optimizations>, p_parent=0x0, i_pos=-666, i_flags=0, p_input=0x0) at tree.c:70
#6  0x000000010003b520 in playlist_Create (p_parent=0x100214de8) at engine.c:211
#7  0x0000000100029c52 in libvlc_InternalInit (p_libvlc=0x100214de8, i_argc=4, ppsz_argv=0x7fff5fbff6c0) at libvlc.c:795
#8  0x0000000100005787 in libvlc_new (argc=4, argv=0x7fff5fbff740) at core.c:59
#9  0x0000000100001a12 in main (i_argc=<value temporarily unavailable, due to optimizations>, ppsz_argv=<value temporarily unavailable, due to optimizations>) at vlc.c:205

This is probably due to something obvious, which I fail to see. Do you have an idea?

Testing done on Mac OS X 10.6, compiled using clang 3.0 (pre-release), but I don't think this is related ;)


Thanks!

Felix