[vlc-devel] vo/xcb: fix a memory leak in Open()

Rémi Denis-Courmont remi at remlab.net
Mon Jul 18 10:51:42 CEST 2011


On Mon, 18 Jul 2011 15:46:02 +0800, Can Wu <wu.canus at gmail.com> wrote:
> ---
>  modules/video_output/xcb/xvideo.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Your patch is correct. Good catch.

Nevertheless, I think it would better to swap var_InheritBool() and
malloc(). Then we do not need the free() call.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list