[vlc-devel] [PATCH 2/5] Qt: PrefsItemData search

Jean-Baptiste Kempf jb at videolan.org
Wed Jul 27 02:25:51 CEST 2011


On Wed, Jul 27, 2011 at 12:17:34AM +0300, Yuval Tze wrote :
> add contains function to search text in item's name, help and in the config items' text

> +/* go over the module config items and search text in psz_text
> + * also search the module name and head */

head? You mean longname?shortname?desc?

> +            if(  p_item->i_type == CONFIG_SUBCATEGORY &&
> +                            ( ( this->i_type == TYPE_SUBCATEGORY &&
> +                              p_item->value.i == this->i_object_id ) ||
> +                            ( this->i_type == TYPE_CATSUBCAT &&
> +                              p_item->value.i == this->i_subcat_id ) ) )

Weird parenthesis placement or indentation.

Else, ok.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list