[vlc-devel] [PATCH 1/5] Qt: Remove leading line break on modules prefs help text

Yuval Tze yuvaltze at gmail.com
Wed Jul 27 20:21:33 CEST 2011


There is only one assignment of TYPE_MODULE (in
AdvPrefsPanel::AdvPrefsPanel) and its help (and name) stay empty
At the else part in AdvPrefsPanel::AdvPrefsPanel, data->i_type could only be
TYPE_MODULE (TYPE_CATEGORY exits at the beginning) so it's safe to assume
that data->help is empty

Anyway I've actually went and printed all the tree items just to be sure..


On Wed, Jul 27, 2011 at 3:22 AM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Wed, Jul 27, 2011 at 12:17:33AM +0300, Yuval Tze wrote :
> > module initial help value was always empty, causing leading line break
> when appending module psz_help text.
> > save name and help in modules' PrefsItemData like other prefs items.
>
> Provided this is correctly tested, it seems ok.
>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110727/3046a5d2/attachment.html>


More information about the vlc-devel mailing list