[vlc-devel] [RFO] Android configure detection

Jean-Baptiste Kempf jb at videolan.org
Wed Jun 1 21:17:38 CEST 2011


On Wed, Jun 01, 2011 at 10:15:04PM +0300, Rémi Denis-Courmont wrote :
> Le mercredi 1 juin 2011 17:47:34 Jean-Baptiste Kempf, vous avez écrit :
> > Android is a linux, so I believe (but might be wrong) that SYS should still
> > be linux. So I declare a HAVE_ flag depending on the presence of the
> > compiler defines.
> 
> I would run the test outside (i.e. after) the big case switch for flexibility 
> and readability. You may still use AS_IF([test "$SYS" = linux],...).

OK. Will do.

> > This might be wrong, so please give me ideas.
> 
> I can't think of any cleaner way to determine that in autoconf or in automake. 
> We already do this for Qt4-X11. But please use AC_MSG_... when running tests.

OK. I planned to use AC_MSG afterwards, when the general idea was ok.

I prefer this way that the way ivoire was using before (and was
reverted, IIRC)

Will update the patch ASAP.


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list