[vlc-devel] [PoC] Android Surface video output

[Jean-Baptiste Kempf]

On Wed, Jun 01, 2011 at 11:25:18PM +0300, Rémi Denis-Courmont wrote :
> Inline.

Thx

> Encoding?
aww... crap /me

> > #ifndef ANDROID_SYM_S_LOCK
> > # define ANDROID_SYM_S_LOCK "_ZN7android7Surface4lockEPNS0_11SurfaceInfoEb"
> > #endif
> > #ifndef ANDROID_SYM_S_UNLOCK
> > # define ANDROID_SYM_S_UNLOCK "_ZN7android7Surface13unlockAndPostEv"
> > #endif
> 
> Vomitive but apparently unavoidable.

You are polite :D

> >     set_capability("vout display", 250)
> 
> Not according to the "guidelines" set in 73d27a4e.

Indeed, this is wrong.©®

> >     if (!p_library) {
> >         msg_Err(vd, "Could not initialize libui.so/libsurfaceflinger_client.so!");
> >         return VLC_EGENERIC;
> >     }
> 
> This is not re-entrant.

ok.

> >     /* Setup chroma */
> >     const char *chroma_format = "RV32";
> >     vlc_fourcc_t chroma = vlc_fourcc_GetCodecFromString(VIDEO_ES, chroma_format);
> 
> I don't see the point of that if chroma is constant.

Yeah, I asked the same, but as this module might evolve, in the future,
this was set like this. I can remove it for now though.

> >     if (!sys->pool)
> >         sys->pool = picture_pool_NewFromFormat(&vd->fmt, count);
> 
> Does it really make sense to have more than one picture in this case?

I'll let other people answer that one. Sébastien? Ludo?

> In principles, this should be done by the picture Lock callback. Otherwise, it would be better in Prepare than in Display, except for "post".
Ok.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device