[vlc-devel] compat pthread_cancel

[Rémi Denis-Courmont]

Le jeudi 2 juin 2011 19:03:03 Jean-Baptiste Kempf, vous avez écrit :
> On Thu, Jun 02, 2011 at 06:58:57PM +0300, Rémi Denis-Courmont wrote :
> > Le jeudi 2 juin 2011 18:47:48 Jean-Baptiste Kempf, vous avez écrit :
> > > Taken from the vlc-android tree, and rebased/merged/fixed, here is the
> > > pthread_cancel for compat.
> > 
> > This seems to interfere with Win32.
> 
> Hmm... Ok, easy to fix in configure.ac. Will do.
> 
> > And then, either this whole thing makes no sense or it relies on
> > super-POSIX properties of Android libc that I don't know and thus cannot
> > review.
> 
> Arf... What parts seem dubious?

In my world:
* Signal handlers are (unfortunately) per-process, not per-thread.
* Setting thread keys to zero is pointless.
* POSIX thread functions are not async-signal-safe, meaning they are not 
defined within signal handlers.
* pthread_setcancelstate() is not a cancellation point.

I also don't understand where cancellation cleanup handlers (vlc_cleanup_push 
and friends) are dealt with.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis