[vlc-devel] [PATCH 1/2] Use CCT to format subtitiles text properly.

[Tomer Barletz]

On Mon, Jun 6, 2011 at 2:35 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Mon, Jun 06, 2011 at 02:29:18AM -0700, Tomer Barletz wrote :
>> Apply Laurent's comments.
>> ---
>>          else if (code == 0x80)
>> @@ -79,9 +103,9 @@ static char *ParseText(uint8_t *data, int size)
>>              snprintf(tmp, sizeof(tmp), "<u>");
>>          else if (code == 0x83)
>>              snprintf(tmp, sizeof(tmp), "</u>");
>> -#endif
>>          else if (code == 0x8a)
>>              snprintf(tmp, sizeof(tmp), "\n");
>> +#endif
>
> You still didn't explain that, did you?
>
> Best Regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>

Including these lines creates a double '\n', effectively doubles the
gap between each line.
I suspect that the subtitles text already contains a '\n' character,
but it might be true only for the single stream I've tested the code.
This is why I left the code commented out, so we may test other
streams and see if this behaviour persist.

Tomer