[vlc-devel] [PATCH] LUA HTTP interface

[Jean-Baptiste Kempf]

On Wed, Jun 15, 2011 at 07:21:59AM -0400, brandon at thebrooksfamilyonline.com wrote :
> 1) Yes, I realized it removed this functionality. I am already in
> progress of putting it back in and building it into the interface.

Great.

> 2) I will put up some pix and link to them in the next patch

Great²

> 3) I will have to investigate the licenses for flowplayer, jQuery's
> themes, and jstree, though I do not anticipate a problem.

GPL, for all of them.

> 4) I had started a mosaic wizard, though I wanted the core
> functionality to be present. After the issues listed here, I will
> continue work on the additional functionality

This is not a priority, IMVHO.

> 5) I am sorry it is such a big patch. I started working on this for
> v1.1.9, and then realized it was all going to change in v1.2, so I
> had most of the work completed. I can try to break it up into
> multiple patches

1 patch = 1 functionnality.
If it can't be broken easily in multiple patches, so be it. People will have to
live with it. Artificial split is just brain-dead.
I suggested libs in one patch and the core development in another one.

> 6) I am not sure what went wrong with the patch, but I'll double
> check when I break it into multiple patches.

Maybe just give a link to it.

> 7) As j-b said, it's his fault. :)
Yep. Only people doing nothing don't make mistakes.

> Including flowplayer, and jquery
> will also increase the overhead of the patch. :( I am also not a fan
> of mandatory internet access.
See above.

> I guess for now, disregard this patch until I address the above
> issues. I will send another update once complete.

Great. Thanks a lot for this work.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device