[vlc-devel] [PATCH] Luahttp can access equalizer settings

[Laurent Aimar]

Hi,

On Fri, Jun 24, 2011 at 02:56:11AM +0530, akash mehrotra wrote:
> Some more minor fixes.
> I hope its correct this time.

> @@ -51,6 +52,12 @@ static int vlclua_preamp_get( lua_State *L )
>      if( p_input )
>      {
>          aout_instance_t *p_aout = input_GetAout( p_input );
> +        char *psz_af = var_GetNonEmptyString( p_aout, "audio-filter" );
> +        if ( !p_aout || strstr ( psz_af, "equalizer" ) == NULL )
 The p_aout check seems badly placed, var_Get* should not be called on
NULL objects.
 var_GetNonEmptyString will return NULL for empty strings, and then strstr()
will probably segfault.

(Same for the following ones).

-- 
fenrir