[vlc-devel] [PATCH 2/2] Mozilla FullScreen support, attempt 3

Sergey Radionov rsatom at gmail.com
Fri Jun 24 07:21:59 CEST 2011

23.06.2011 23:15, Rémi Denis-Courmont пишет:
> Le samedi 18 juin 2011 11:31:22 Sergey Radionov, vous avez écrit :
> Is there any particular reason why you define DllGetModule() instead of making
> the global variable extern?

I only think that function is more clear than extern variable - it give more clarity where to find 
definition of this function (in relative .cpp), but extern variable can be defined anywhere in 
source tree...
And second reason - DllGetModule already exist in ActiveX plugin... so it can make Mozilla and 
ActiveX code more similar...
But you are right, there is no special need in DllGetModule, so it can be removed painlessly...

With best wishes,
Sergey Radionov

More information about the vlc-devel mailing list