[vlc-devel] [PATCH] Luahttp can access equalizer settings

[akash mehrotra]

On 6/24/11, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le vendredi 24 juin 2011 00:26:11 akash mehrotra, vous avez écrit :
>> Some more minor fixes.
>> I hope its correct this time.
>
> I don't think the while loop condition is correct. tmp will never become
> NULL,
> and the process will busy loop.
Wont us_strtof make tmp NULL if the string terminates?

You should probably use strtok_r() or
> strsep()
> anyway.
>
is there any advantage to changing it to use these?
They would make the code more complex unnecessarily
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>