[vlc-devel] [PATCH] Luahttp can access equalizer settings

akash mehrotra mehrotra.akash at gmail.com
Wed Jun 29 19:04:30 CEST 2011


Fixed and attached as per IRC discussion

2011/6/26 Rémi Denis-Courmont <remi at remlab.net>

> Le samedi 25 juin 2011 21:49:56 akash mehrotra, vous avez écrit :
> > Made the following changes:
> >
> >    1. release p_input early
> >    2. use sizeof for snprintf
> >
> >
> > Did not use strtok as the code would become more complicated ( us_strtof
> > works well enough )
> > Did not change the while loop, it works as it is ( the 2nd argument of
> > us_strtof will become null if the string terminates earlier than
> expected.
> > this is the case in which the null condition will be used to end the
> loop)
>
> Negative acknowledgement. Patch rejected.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> http://fi.linkedin.com/in/remidenis
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110629/853cce5d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Luahttp-can-access-and-modify-equalizer-settings.patch
Type: application/octet-stream
Size: 7822 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110629/853cce5d/attachment.obj>


More information about the vlc-devel mailing list