[vlc-devel] DASH access plugin

Jean-Baptiste Kempf jb at videolan.org
Thu Mar 3 12:13:02 CET 2011

On Wed, Mar 02, 2011 at 01:30:19PM +0100, Christopher Müller wrote :
> I have formatted the source as git patches as discussed and fixed the minor
> issues that you have mentioned.

Thanks for the update. This is nice.

However, you should send the patches directly in plain text on this
mailing list, because reviewers tends to be lazy...

You should fix your git authorship, see
http://wiki.videolan.org/Git#Configure_your_global_git_config :D

You should probably use "" for inclusion of local files, and not <>

You should remove some tabs that are still present and remove excessive
white lines at the end of the files.

You should use forward-declarations of classes to reduce compilation
time (cosmetics, I agree).

NullAdaptationLogic could be entirely in the header and same for BaseUrl

p_access->psz_demux = strdup("ffmpeg"); should probably be "avformat"

You should check malloc return in Open()
You sould free structures, and not delete them.

Best Regards,

Jean-Baptiste Kempf
+33 672 704 734

More information about the vlc-devel mailing list