[vlc-devel] Deinterlacer broken, possibly a PTS issue - any ideas?

[Juha Jeronen]

Hi all,

Here's the result from git bisect:

---8<---8<---8<---

8f85c827640f78e4b5bdc8e83c733ff62c624b7b is the first bad commit
commit 8f85c827640f78e4b5bdc8e83c733ff62c624b7b
Author: Laurent Aimar <fenrir at videolan.org>
Date:   Tue Dec 14 20:57:32 2010 +0100

    Reworked the code doing the blending in vout.
   
    It is a bit cleaner and properly check for slow write pictures. It also
    prepare for letting the vout display to do the blending, and when not
    available to blend after the resize (not activated).

:040000 040000 cfd178823d32b30eed5539a8a99cb2f40dda58c6
3290357c799ecf5e21d29d31724a554b63f51d93 M      src

---8<---8<---8<---

Here is the last good commit (the one just before the above):

---8<---8<---8<---

commit 07498c200c78fb637d0f7a16ac040667c755a532
Author: Laurent Aimar <fenrir at videolan.org>
Date:   Mon Dec 13 20:33:15 2010 +0100

    Fixed typo in vout subpicture rendering regarding AR.

---8<---8<---8<---

But... both are from December? I thought I had updated my copy in
January? Indeed, I did, as the log confirms. Here's a snippet a bit
further down - I used to have 3f50c72...:

---8<---8<---8<---

commit 81f8f88d654bc5b47595b044ba5833e11f12d2d6
Author: Laurent Aimar <fenrir at videolan.org>
Date:   Sat Dec 11 18:32:42 2010 +0100

    Added picture_BlendSubpicture helper.
   
    It blends a subpicture onto a picture.

commit 212661f3ddca4c59724edff7fa21985783feeb8b
Author: Laurent Aimar <fenrir at videolan.org>
Date:   Sun Jan 9 22:29:29 2011 +0100

    Revert "Fix render picture out-of-memory handling"
   
    This reverts commit 8acffd0c9b4f5cd08e1ff306f204c1f2a864a583.
   
    It has nothing to do with the patch in itself (which is perfectly fine)
    but it conflicts too much with the following patches (which will
also fix
    the issue). I hope it's ok.

commit 3f50c72acbf4fe8ca4f9631a3bff596cba2d3a05
Author: Laurent Aimar <fenrir at videolan.org>
Date:   Sun Jan 9 21:49:34 2011 +0100

    Properly reset pictures created for vout filters.

---8<---8<---8<---

So it seems that some changes have been applied in January that were
worked on in December, and the commit breaking the deinterlacer
(8f85c827640f78e4b5bdc8e83c733ff62c624b7b) is one of those.

 -J


On 03/04/2011 09:49 AM, Rémi Denis-Courmont wrote:
> On Fri, 04 Mar 2011 06:12:07 +0200, Juha Jeronen <juha.jeronen at jyu.fi>
> wrote:
>> I updated my vlc-1.2-git tree two days ago, and since then the
>> deinterlacer module has stopped working properly for many streams.
>>
>> I'm getting bursts of late frames (up to 200ms or so), which causes the
>> playback to seriously stutter. This didn't happen with the version of
>> vlc-1.2-git from early January I had earlier.
> If you have a known good older version, you can find the faulty commit with
> git-bisect.
>
> At that point, I'll cross my finders so that it turns out to be Laurent's
> fault rather than mine :D