[vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 3

Rémi Denis-Courmont remi at remlab.net
Mon Mar 7 20:21:06 CET 2011


Le dimanche 6 mars 2011 01:26:57 Juha Jeronen, vous avez écrit :
> Patch split into two as suggested. Aside from that, I updated some of
> the new comments and removed an unused parameter that was accidentally
> left in in the previous version.
> Please review the attached version. If needed, I can make one more round
> of changes for this set. After that, I think it's time to declare this
> set complete :)

If I understood the first patch correctly, you're hacking the pitch and 
visible pitch to only copy every second scan line. I'm not sure this belongs 
in the core, if it is only used internally by the deinterlacer. Or if it still 
goes to the core, it may need to be a little bit "cleaner"?

In any case, I would recommend wrapping source code to 79 columns or less. I 
know Laurent is sometimes sloppy. But until you get commit rights, you'll have 
to cope with nit-picking people like myself :P

Rémi Denis-Courmont

More information about the vlc-devel mailing list