[vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 4

Juha Jeronen juha.jeronen at jyu.fi
Wed Mar 16 22:42:20 CET 2011

Hi all (especially Laurent and Rémi),

Long time no update from me. So, here's an update :)

Attached is my updated Phosphor patch, hereby submitted for review.
Thanks for the previous comments as always. This is much cleaner than
the original.

I ended up combining your suggestions. Please check if this version is
ok or if it needs further tuning :)


- Patch 1: plane_CopyPixels() has been changed to check for pitch >=
2*visible_pitch, but now no new exports are needed in the core. The
field plane handling is now entirely internal to the deinterlacer. This
should be cleaner than the original.

- Patch 2: moved "#undef Merge" to after ComposeFrame() (which is now
the last function that needs it). This is not as clean as it used to be,
but I think this change is not harmful. In any case it's a very minor
point, because the issue will become moot with the soon-upcoming
refactoring of the module.

- Both patches: all new additions have been wrapped to 79 columns


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-field-plane_t-s-in-plane_CopyPixels.patch
Type: text/x-patch
Size: 1148 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110316/1ced8d93/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Phosphor-deinterlacer.patch
Type: text/x-patch
Size: 45180 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110316/1ced8d93/attachment-0001.bin>

More information about the vlc-devel mailing list