[vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 4

Rémi Denis-Courmont remi at remlab.net
Sun Mar 20 21:23:52 CET 2011

Le mercredi 16 mars 2011 23:42:20 Juha Jeronen, vous avez écrit :
> - Patch 1: plane_CopyPixels() has been changed to check for pitch >=
> 2*visible_pitch, but now no new exports are needed in the core. The
> field plane handling is now entirely internal to the deinterlacer. This
> should be cleaner than the original.

Merged, thanks.

> - Patch 2: moved "#undef Merge" to after ComposeFrame() (which is now
> the last function that needs it). This is not as clean as it used to be,
> but I think this change is not harmful. In any case it's a very minor
> point, because the issue will become moot with the soon-upcoming
> refactoring of the module.

I wonder if the long text is not too long for the user interface (not tested).

Otherwise, you should really cache vlc_CPU(). The compiler does not know that 
it's constant. This is a stupid limitation of Windows DLL, which cannot export 
global variables...

Rémi Denis-Courmont

More information about the vlc-devel mailing list